feat: support file API reading #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/fileapi
branch
from
bdae0b6 to
ddd6ab2
Compare
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/fileapi
branch
3 times, most recently
from
d39f5dd to
7b87172
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/fileapi
branch
from
7b87172 to
f6a29b3
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/fileapi
branch
2 times, most recently
from
40e8772 to
f3340bc
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/fileapi
branch
from
f3340bc to
653c9d9
Compare
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
|
This is entirely optional at the moment, so I think it's safe in, will likely change once we start needing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the FileAPI to query information about the build system from CMake. Will likely be very important for PEP 660 support, extensionlib support, and Setuptools 62+ support for editable mode.
I originally used cattrs for the JSON reader, but dropped it due to python-attrs/cattrs#253 - PyPy support was broken and was fixed quickly on April 15, but still hasn't been released. We can't afford to have PyPy broken by our dependencies, so no cattrs. But I still included the cattrs version for the tests. I loved the usage of exceptiongroup, so I kept that (and we use
__notes__instead of__note__, awaiting merge for cattrs in python-attrs/cattrs#303).TODO: Finish the rest of the API, I was originally not covering everything when writing code model. Also consider if automatically loading jsonFile is best - one case (Directory) is odd because it looks like the class holds different info than the file it looks up. I'm biased toward keeping this close to source, so maybe we could add the looked up file in an attribute instead.
@jcfr or @thewtex, any thoughts about supplying testing files for this?